Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OurEvents #44

Merged

Conversation

Daredevil124
Copy link
Contributor

@Daredevil124 Daredevil124 commented Dec 27, 2024

Related Issue

Solves/Resolves/Fixes #9.


Description

Provide a detailed explanation of the changes made in this Pull Request [PR].

  • Added ourEvents component

Checklist

Please ensure the following before submitting the PR:

  • I have read the CODE_OF_CONDUCT.md file and followed it's guidlines.
  • I have followed the design specified in the Figma file (if applicable).

Additional Comments

Include any additional notes or comments for the reviewers. If applicable, mention dependencies, challenges faced, or potential improvements.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for au-pclub ready!

Name Link
🔨 Latest commit ce789e6
🔍 Latest deploy log https://app.netlify.com/sites/au-pclub/deploys/676eda8fc603c800081af55e
😎 Deploy Preview https://deploy-preview-44--au-pclub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Saumya40-codes
Copy link
Member

Looks Perfect 🚀

Nice work @Daredevil124 !!!!

@Saumya40-codes
Copy link
Member

Can you update the folder name to OurEvents instead of ExampleComponent, will be more descriptive, so as to what it is.

@Daredevil124
Copy link
Contributor Author

yea sure

@Daredevil124
Copy link
Contributor Author

I have committed and pushed the new code. Would you like me to make a new pull request?

@Saumya40-codes
Copy link
Member

Saumya40-codes commented Dec 27, 2024

I have committed and pushed the new code. Would you like me to make a new pull request?

No all good.

Just make sure that when you make pr or create a new branch it is in line with the base branch

i.e. in your forked repo in main (or default one) branch if there is option to Sync Fork and the update then do it before creating a new branch/pr. This helps from avoiding merge conflict.

LGTM 🚀 otherwise.

@Saumya40-codes Saumya40-codes merged commit 837b817 into Programming-Club-Ahmedabad-University:main Dec 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component][Design]: Create an Our Events component
2 participants